Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3313)

Issue 6297043: cmd/5c, cmd/5g, cmd/5l: fix array indexing warning under Clang 3.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by dfc
Modified:
11 years, 9 months ago
Reviewers:
CC:
golang-dev, minux1, rsc
Visibility:
Public.

Description

cmd/5c, cmd/5g, cmd/5l: fix array indexing warning under Clang 3.1 This should be the last of them.

Patch Set 1 #

Patch Set 2 : diff -r f1028a23b059 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f1028a23b059 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0b5426350053 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r f5904003a449 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/cmd/5c/list.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5g/list.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5l/list.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 9 months ago (2012-06-05 08:06:55 UTC) #1
minux1
I really think this is a clang bug, not ours. does clang have a flag ...
11 years, 9 months ago (2012-06-05 09:47:01 UTC) #2
rsc
LGTM But change the CL description to say cmd/5c, cmd/5g, cmd/5l: which works better with ...
11 years, 9 months ago (2012-06-05 14:10:08 UTC) #3
dfc
On 2012/06/05 09:47:01, minux wrote: > I really think this is a clang bug, not ...
11 years, 9 months ago (2012-06-05 21:28:50 UTC) #4
dfc
*** Submitted as http://code.google.com/p/go/source/detail?r=9b455eb64690 *** cmd/5c, cmd/5g, cmd/5l: fix array indexing warning under Clang 3.1 ...
11 years, 9 months ago (2012-06-05 22:19:14 UTC) #5
rsc
11 years, 9 months ago (2012-06-05 23:57:59 UTC) #6
Thanks for cleaning these up. It's good to be warning-free.

Russ
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b