Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14016)

Issue 6035054: code review 6035054: lib9: fix warning under clang 3.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by dave
Modified:
11 years, 11 months ago
Reviewers:
minux1, M-A
CC:
golang-dev, rsc
Visibility:
Public.

Description

lib9: fix warning under clang 3.1 Fixes issue 3534.

Patch Set 1 #

Patch Set 2 : diff -r 0324cadd9b98 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0324cadd9b98 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2d10e34b8820 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/lib9/ctime.c View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
dave_cheney.net
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years ago (2012-04-16 21:27:38 UTC) #1
rsc
LGTM i see that clang is taking after gcc...
12 years ago (2012-04-16 21:29:49 UTC) #2
dave_cheney.net
*** Submitted as http://code.google.com/p/go/source/detail?r=73a10f76098b *** lib9: fix warning under clang 3.1 Fixes issue 3534. R=golang-dev, ...
12 years ago (2012-04-17 23:57:19 UTC) #3
M-A
On 2012/04/17 23:57:19, dfc wrote: > *** Submitted as http://code.google.com/p/go/source/detail?r=73a10f76098b *** Can this specific commit ...
11 years, 11 months ago (2012-05-10 12:42:18 UTC) #4
rsc
On Thu, May 10, 2012 at 8:42 AM, <maruel@chromium.org> wrote: > Can this specific commit ...
11 years, 11 months ago (2012-05-10 17:37:10 UTC) #5
minux1
11 years, 11 months ago (2012-05-10 17:40:30 UTC) #6
On Fri, May 11, 2012 at 1:36 AM, Russ Cox <rsc@golang.org> wrote:

> On Thu, May 10, 2012 at 8:42 AM,  <maruel@chromium.org> wrote:
> > Can this specific commit be merged into branch release-branch.go1 or is
> > it out of scope at that point? That's the only snag I hit when building
> > this branch when building with
> >>
> >> $CC --version
> >
> > clang version 3.2 (trunk 155835)
>
> i created issue 3602 to remember to move it over for go 1.0.2.
>
actually it's issue 3608.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b