Issue 6242066: code review 6242066: undo CL 6248054 / 0f418a63cdf9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6242066: code review 6242066: undo CL 6248054 / 0f418a63cdf9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by mikio

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

undo CL 6248054 / 0f418a63cdf9 breaks public API document style ««« original CL description net: fix comment on FileListener R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6248054 »»»

Patch Set 1 #

Patch Set 2 : diff -r a1ecb826e0eb https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 798239220647 https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/pkg/net/file.go	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-05-29 16:32:36 UTC) #1

rsc

LGTM It's fine if you want to s/c/f/ here, as that appears to be the ...

13 years, 2 months ago (2012-05-29 16:33:46 UTC) #2

mikio

13 years, 2 months ago (2012-05-29 16:42:44 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ebad821df79b ***

undo CL 6248054 / 0f418a63cdf9

breaks public API document style

««« original CL description
net: fix comment on FileListener

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6248054
»»»

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6242066

Expand All Messages | Collapse All Messages