code review 6248054: net: fix comment on FileListener

net: fix comment on FileListener

[mikio, 2012-05-27 10:29:55]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-05-27 15:09:13]

LGTM

On Sun, May 27, 2012 at 3:29 AM, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: fix comment on FileListener
>
> Please review this at
http://codereview.appspot.com/**6248054/<http://codereview.appspot.com/6248054/>
>
> Affected files:
>  M src/pkg/net/file.go
>
>
> Index: src/pkg/net/file.go
> ==============================**==============================**=======
> --- a/src/pkg/net/file.go
> +++ b/src/pkg/net/file.go
> @@ -88,10 +88,10 @@
>  }
>
>  // FileListener returns a copy of the network listener corresponding
> -// to the open file f.  It is the caller's responsibility to close l
> -// when finished.  Closing c does not affect l, and closing l does not
> -// affect c.
> -func FileListener(f *os.File) (l Listener, err error) {
> +// to the open file f.  It is the caller's responsibility to close ln
> +// when finished.  Closing ln does not affect f, and closing f does not
> +// affect ln.
> +func FileListener(f *os.File) (ln Listener, err error) {
>        fd, err := newFileFD(f)
>        if err != nil {
>                return nil, err
>
>
>

[mikio, 2012-05-28 21:14:05]

*** Submitted as http://code.google.com/p/go/source/detail?r=0f418a63cdf9 ***

net: fix comment on FileListener

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6248054

[rsc, 2012-05-29 16:23:01]

Every other variable in the public net API is one letter. Why the push
for ln? Please revert this.