Issue 5756075: code review 5756075: undo CL 5754063 / e23b66fcfc94

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5756075: code review 5756075: undo CL 5754063 / e23b66fcfc94 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, minux1, r, f_souza.cc

Visibility:
Public.

Description

undo CL 5754063 / e23b66fcfc94 Does not actually test so files. ««« original CL description misc/cgo: re-enable testso Also enabled it for darwin. R=rsc CC=golang-dev http://codereview.appspot.com/5754063 Committer: Russ Cox <rsc@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r fb477fcfa20b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5c664f190e4e https://code.google.com/p/go/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -8 lines)			Patch
misc/cgo/testso/Makefile	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
misc/cgo/testso/cgoso_test.go	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
misc/cgo/testso/main.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
misc/cgo/testso/test.bash	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
src/run.bash	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 2 months ago (2012-03-07 07:23:13 UTC) #1

minux1

On 2012/03/07 07:23:13, rsc wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

13 years, 2 months ago (2012-03-07 09:17:31 UTC) #2

f_souza.cc

On Wed, Mar 7, 2012 at 6:17 AM, <minux.ma@gmail.com> wrote: > On 2012/03/07 07:23:13, rsc ...

13 years, 2 months ago (2012-03-07 12:20:44 UTC) #4

rsc

13 years, 2 months ago (2012-03-07 15:15:26 UTC) #5

*** Submitted as f2d3e4301f75 ***

undo CL 5754063 / e23b66fcfc94

Does not actually test so files.

««« original CL description
misc/cgo: re-enable testso

Also enabled it for darwin.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5754063

Committer: Russ Cox <rsc@golang.org>
»»»

R=golang-dev, minux.ma, r, f
CC=golang-dev
http://codereview.appspot.com/5756075

Expand All Messages | Collapse All Messages