Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 5754063: code review 5754063: misc/cgo: re-enable testso (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by fss
Modified:
13 years, 2 months ago
Reviewers:
remyoudompheng
CC:
rsc, golang-dev
Visibility:
Public.

Description

misc/cgo: re-enable testso Also enabled it for darwin

Patch Set 1 #

Patch Set 2 : diff -r 2b1a6605a310 https://code.google.com/p/go #

Patch Set 3 : diff -r 2b1a6605a310 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -46 lines) Patch
R misc/cgo/testso/Makefile View 1 1 chunk +0 lines, -22 lines 0 comments Download
A misc/cgo/testso/cgoso_test.go View 1 1 chunk +7 lines, -0 lines 0 comments Download
R misc/cgo/testso/main.go View 1 1 chunk +0 lines, -11 lines 0 comments Download
R misc/cgo/testso/test.bash View 1 1 chunk +0 lines, -9 lines 0 comments Download
M src/run.bash View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5
fss
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
13 years, 2 months ago (2012-03-07 05:36:39 UTC) #1
rsc
LGTM
13 years, 2 months ago (2012-03-07 05:40:06 UTC) #2
rsc
*** Submitted as e23b66fcfc94 *** misc/cgo: re-enable testso Also enabled it for darwin. R=rsc CC=golang-dev ...
13 years, 2 months ago (2012-03-07 05:40:19 UTC) #3
remyoudompheng
Le 7 mars 2012 06:40, <rsc@golang.org> a écrit : > *** Submitted as e23b66fcfc94 *** ...
13 years, 2 months ago (2012-03-07 07:21:30 UTC) #4
rsc
13 years, 2 months ago (2012-03-07 07:22:32 UTC) #5
My bad, sorry.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b