Issue 5709050: code review 5709050: net/http/httputil: fix DumpRequestOut on https URLs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5709050: code review 5709050: net/http/httputil: fix DumpRequestOut on https URLs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bradfitz

Modified:
12 years, 1 month ago

Reviewers:
rsc

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

net/http/httputil: fix DumpRequestOut on https URLs Don't try to do an SSL negotiation with a *bytes.Buffer. Fixes issue 3135

Patch Set 1 #

Patch Set 2 : diff -r b4580a3b3331 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b4580a3b3331 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b4580a3b3331 https://go.googlecode.com/hg/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	M	src/pkg/net/http/httputil/dump.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
	M	src/pkg/net/http/httputil/dump_test.go	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 1 month ago (2012-02-28 23:59:26 UTC) #1

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=ab1c71f65fe7 *** net/http/httputil: fix DumpRequestOut on https URLs Don't try to do ...

12 years, 1 month ago (2012-02-29 00:03:31 UTC) #3

rsc

I hate to be a spoilsport, but editing req.URL this way does not seem safe. ...

12 years, 1 month ago (2012-02-29 05:06:10 UTC) #4

bradfitz

12 years, 1 month ago (2012-02-29 08:56:24 UTC) #5

On Tue, Feb 28, 2012 at 9:06 PM, <rsc@golang.org> wrote:

> I hate to be a spoilsport, but editing req.URL this way does not seem
> safe.  What if the URL is shared across multiple requests?
>

Better? http://codereview.appspot.com/5709054

Expand All Messages | Collapse All Messages