Issue 5709054: code review 5709054: net/http/httputil: make https DumpRequestOut less racy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5709054: code review 5709054: net/http/httputil: make https DumpRequestOut less racy (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bradfitz

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net/http/httputil: make https DumpRequestOut less racy It's still racy in that it mutates req.Body, though. *shrug*

Patch Set 1 #

Patch Set 2 : diff -r ab1c71f65fe7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ab1c71f65fe7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 25d11b1ccc57 https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	src/pkg/net/http/httputil/dump.go	View	1	3 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2012-02-29 08:56:46 UTC) #1

rsc

LGTM Thanks. I think it's fine to treat the Request as mutable, since req.Body obviously ...

12 years, 2 months ago (2012-02-29 16:49:01 UTC) #2

bradfitz

12 years, 2 months ago (2012-02-29 17:52:26 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=3cfa14662422 ***

net/http/httputil: make https DumpRequestOut less racy

It's still racy in that it mutates req.Body, though.  *shrug*

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5709054

Expand All Messages | Collapse All Messages