Issue 4962058: code review 4962058: [release-branch.r60] gofix: do not convert url in field...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4962058: code review 4962058: [release-branch.r60] gofix: do not convert url in field... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by adg

Modified:
13 years, 7 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

[release-branch.r60] gofix: do not convert url in field names ««« CL 4972052 / 0f7a647510f9 gofix: do not convert url in field names There's some ambiguity in the U{url: url} case as it could be both a map or a struct literal, but given context it's more likely a struct, so U{url: url_} rather than U{url_: url_}. At least that was the case for me. R=golang-dev, rsc, adg CC=golang-dev http://codereview.appspot.com/4972052 »»»

Patch Set 1 #

Patch Set 2 : diff -r 5c347c57f6c7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5c347c57f6c7 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
	M	src/cmd/gofix/url.go	View	1	3 chunks	+12 lines, -1 line	0 comments	Download
	M	src/cmd/gofix/url_test.go	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-09-08 00:51:51 UTC) #1

adg

13 years, 7 months ago (2011-09-08 00:52:34 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=18a45b53424c ***

[release-branch.r60] gofix: do not convert url in field names

««« CL 4972052 / 0f7a647510f9
gofix: do not convert url in field names

There's some ambiguity in the U{url: url} case as it could be
both a map or a struct literal, but given context it's more
likely a struct, so U{url: url_} rather than U{url_: url_}.
At least that was the case for me.

R=golang-dev, rsc, adg
CC=golang-dev
http://codereview.appspot.com/4972052
»»»

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4962058

Expand All Messages | Collapse All Messages