code review 4972052: gofix: do not convert url in field names

gofix: do not convert url in field names

There's some ambiguity in the U{url: url} case as it could be
both a map or a struct literal, but given context it's more
likely a struct, so U{url: url_} rather than U{url_: url_}.
At least that was the case for me.

[niemeyer, 2011-08-31 11:13:16]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-08-31 11:25:29]

> There's some ambiguity in the U{url: url} case as it could be
> both a map or a struct literal, but given context it's more
> likely a struct, so U{url: url_} rather than U{url_: url_}.
> At least that was the case for me.

Sounds reasonable.

It doesn't look like you need an after func.
In before:

if skip != nil {
    skip = nil
    return
}

Russ

[niemeyer, 2011-08-31 12:03:21]

> It doesn't look like you need an after func.

PTAL

[adg, 2011-09-02 00:35:50]

LGTM

[niemeyer, 2011-09-03 19:02:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=0f7a647510f9 ***

gofix: do not convert url in field names

There's some ambiguity in the U{url: url} case as it could be
both a map or a struct literal, but given context it's more
likely a struct, so U{url: url_} rather than U{url_: url_}.
At least that was the case for me.

R=golang-dev, rsc, adg
CC=golang-dev
http://codereview.appspot.com/4972052