code review 4777041: 5l: fix arm linker bug introduced by 4742041

5l: fix arm linker bug introduced by 4742041
Should fix the arm build.

[r, 2011-07-19 05:43:19]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-07-19 05:44:01]

LGTM

OMFG

WTF

BBQ

[adg, 2011-07-19 05:44:03]

LGTM

Called it.

[r, 2011-07-19 05:44:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=2705dce7bb96 ***

5l: fix arm linker bug introduced by 4742041
Should fix the arm build.

R=golang-dev, dsymonds, adg
CC=golang-dev
http://codereview.appspot.com/4777041

[r2, 2011-07-19 05:47:25]

that CL number should have been 4752041
http://codereview.appspot.com/4752041
https://code.google.com/p/go/source/detail?r=c6702bb3204da3fa3956ca70137a43d3...

[rsc, 2011-07-19 14:11:10]

On Tue, Jul 19, 2011 at 01:43, David Symonds <dsymonds@golang.org> wrote:
> LGTM
>
> OMFG
>
> WTF
>
> BBQ

this is a simple copy-paste bug from
6l and 8l where the ++ is not necessary
and triggers compile warnings about
set-and-not-used.

in other news the dashboard is working.

[r2, 2011-07-19 20:29:57]

Except crypto/x509's tests are timing out on xoom. Not sure about that one. It's
unlikely your fault.

-rob

[rsc, 2011-07-19 20:35:07]

On Tue, Jul 19, 2011 at 16:29, Rob 'Commander' Pike <r@google.com> wrote:
> Except crypto/x509's tests are timing out on xoom. Not sure about that one.
It's unlikely your fault.

i meant the dashboard is doing its job of finding bugs.

[r2, 2011-07-19 20:41:40]

On 20/07/2011, at 6:35 AM, Russ Cox wrote:

> On Tue, Jul 19, 2011 at 16:29, Rob 'Commander' Pike <r@google.com> wrote:
>> Except crypto/x509's tests are timing out on xoom. Not sure about that one.
It's unlikely your fault.
> 
> i meant the dashboard is doing its job of finding bugs.

reporting them but not fixing them. i spent much of yesterday diagnosing and
fixing arm bugs that could have been avoided being checked in. i'm not saying
should, just could.

-rob

[lucio, 2011-07-20 04:30:33]

I guess there aren't enough Linux/ARM platforms to test on, and
impatient developers like me.  I haven't yet tracked down how I
slipped on 5l (it looks like cut-n-paste, but that's not my normal
behaviour), but I'll follow Rob's suggestion and install an ARM
QEMUlator for the future - after porting bison to Plan 9 :-)

Lucio.

On 7/19/11, Rob 'Commander' Pike <r@google.com> wrote:
>
> On 20/07/2011, at 6:35 AM, Russ Cox wrote:
>
>> On Tue, Jul 19, 2011 at 16:29, Rob 'Commander' Pike <r@google.com> wrote:
>>> Except crypto/x509's tests are timing out on xoom. Not sure about that
>>> one. It's unlikely your fault.
>>
>> i meant the dashboard is doing its job of finding bugs.
>
> reporting them but not fixing them. i spent much of yesterday diagnosing and
> fixing arm bugs that could have been avoided being checked in. i'm not
> saying should, just could.
>
> -rob
>
>

[captn, 2011-07-20 05:48:03]

On 2011/07/20 04:30:33, lucio wrote:
> I guess there aren't enough Linux/ARM platforms to test on, and
> impatient developers like me.  I haven't yet tracked down how I
> slipped on 5l (it looks like cut-n-paste, but that's not my normal
> behaviour), but I'll follow Rob's suggestion and install an ARM
> QEMUlator for the future - after porting bison to Plan 9 :-)
> 
> Lucio.

I would rather suggest buying some cheap development board. 
Threading in qemu is broken and cross-compiling is not at
the Go roadmap any more.

Martin

> 
> On 7/19/11, Rob 'Commander' Pike <mailto:r@google.com> wrote:
> >
> > On 20/07/2011, at 6:35 AM, Russ Cox wrote:
> >
> >> On Tue, Jul 19, 2011 at 16:29, Rob 'Commander' Pike <mailto:r@google.com>
wrote:
> >>> Except crypto/x509's tests are timing out on xoom. Not sure about that
> >>> one. It's unlikely your fault.
> >>
> >> i meant the dashboard is doing its job of finding bugs.
> >
> > reporting them but not fixing them. i spent much of yesterday diagnosing and
> > fixing arm bugs that could have been avoided being checked in. i'm not
> > saying should, just could.
> >
> > -rob
> >
> >