Issue 4752041: code review 4752041: cmd/5*: Adjustments for porting to Plan 9 legacy.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4752041: code review 4752041: cmd/5*: Adjustments for porting to Plan 9 legacy. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by lucio

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/5*: Adjustments for porting to Plan 9 legacy. 5a/a.h: . Removed <u.h> and <lib.h>. . Made definition of EOF conditional. 5a/a.y: . Added <u.h> and <lib.h>. 5a/lex.c: . Added <u.h> and <lib.h>. . Dropped <ctype.h> (now in <u.h>). 5c/peep.c: . Removed unnecessary "return 0" statement. 5c/reg.c: . Added compilation condition around unused code. 5c/swt.c: . Removed unused "thestring" argument from Bprint() calls. 5l/asm.c: . Added USED() statements as required. . Adjusted a few format specifications. . Added compilation condition around unused code. 5l/l.h: . Dropped directory prefix from <../5l/5.out.h>. . Added varargck pragma for "I" and "i". 5l/obj.c: . Cascaded consecutive "if" statements. . Dropped unnecessary incrementation and assignments. 5l/pass.c: . Dropped unnecessary assignment. 5l/prof.c: . #if 0 converted to #ifdef NOTDEF. 5l/span.c: . Dropped unnecessary incrementation and assignments.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -28 lines)			Patch
M	src/cmd/5a/a.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/5a/a.y	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/5a/lex.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/5c/peep.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/5c/reg.c	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/cmd/5c/swt.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/5l/asm.c	View	1	6 chunks	+12 lines, -4 lines	0 comments	Download
M	src/cmd/5l/l.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/5l/obj.c	View	1	4 chunks	+4 lines, -6 lines	0 comments	Download
M	src/cmd/5l/pass.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/5l/prof.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/5l/span.c	View	1	6 chunks	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lucio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-07-15 09:23:45 UTC) #1

rsc

13 years, 9 months ago (2011-07-15 15:58:36 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c6702bb3204d ***

5a, 5c, 5l: fix for Plan 9 build

5a/a.h:
. Removed <u.h> and <lib.h>.
. Made definition of EOF conditional.

5a/a.y:
. Added <u.h> and <lib.h>.

5a/lex.c:
. Added <u.h> and <lib.h>.
. Dropped <ctype.h> (now in <u.h>).

5c/peep.c:
. Removed unnecessary "return 0" statement.

5c/reg.c:
. Added compilation condition around unused code.

5c/swt.c:
. Removed unused "thestring" argument from Bprint() calls.

5l/asm.c:
. Added USED() statements as required.
. Adjusted a few format specifications.
. Added compilation condition around unused code.

5l/l.h:
. Dropped directory prefix from <../5l/5.out.h>.
. Added varargck pragma for "I" and "i".

5l/obj.c:
. Cascaded consecutive "if" statements.
. Dropped unnecessary incrementation and assignments.

5l/pass.c:
. Dropped unnecessary assignment.

5l/prof.c:
. #if 0 converted to #ifdef NOTDEF.

5l/span.c:
. Dropped unnecessary incrementation and assignments.

R=golang-dev
CC=golang-dev, rsc
http://codereview.appspot.com/4752041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages