Issue 4654072: code review 4654072: [release-branch.r58] gopprof: update list of memory all...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4654072: code review 4654072: [release-branch.r58] gopprof: update list of memory all... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by adg

Modified:
13 years, 10 months ago

Reviewers:
r

CC:
rsc, golang-dev

Visibility:
Public.

Description

[release-branch.r58] gopprof: update list of memory allocators ««« CL 4650048 / 09d52e36dab9 gopprof: update list of memory allocators Also import new weblist command from Google version. R=r, bradfitz CC=golang-dev http://codereview.appspot.com/4650048 »»»

Patch Set 1 #

Patch Set 2 : diff -r 3cf2e96881ac https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -46 lines)			Patch
	M	src/cmd/prof/gopprof	View	1	27 chunks	+243 lines, -46 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-06-29 05:40:27 UTC) #1

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=0a283d21ca1f *** [release-branch.r58] gopprof: update list of memory allocators ««« CL 4650048 ...

13 years, 10 months ago (2011-06-29 05:40:35 UTC) #2

LGTM

Expand All Messages | Collapse All Messages