code review 4650048: gopprof: update list of memory allocators

gopprof: update list of memory allocators

Also import new weblist command from Google version.

[rsc, 2011-06-21 03:30:18]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[r, 2011-06-21 03:35:44]

noticed one thing (!) but this needs a perl reviewer. adding bradfitz.

http://codereview.appspot.com/4650048/diff/4001/src/cmd/prof/gopprof
File src/cmd/prof/gopprof (right):

http://codereview.appspot.com/4650048/diff/4001/src/cmd/prof/gopprof#newcode921
src/cmd/prof/gopprof:921: my $total_count = shit;
i think you mean my $total_count = shiFt;

[rsc, 2011-06-21 03:39:03]

>
http://codereview.appspot.com/4650048/diff/4001/src/cmd/prof/gopprof#newcode921
> src/cmd/prof/gopprof:921: my $total_count = shit;
> i think you mean my $total_count = shiFt;

perl already yelled at me about that one.  hmm.
oh i see.  i edited the installed copy in $GOBIN
not the source copy.  uploaded again.

the new perl code is not really new.
it is copied and pasted from the current
google c++ pprof.

[r, 2011-06-21 03:54:17]

LGTM if you want to check it in, but i have no understanding of perl.

[bradfitz, 2011-06-21 04:18:05]

LGTM

http://codereview.appspot.com/4650048/diff/8001/src/cmd/prof/gopprof
File src/cmd/prof/gopprof (right):

http://codereview.appspot.com/4650048/diff/8001/src/cmd/prof/gopprof#newcode1316
src/cmd/prof/gopprof:1316: if (!open(TEMP, ">$fname")) {
if (!open($output, ">$fname")) {
}

http://codereview.appspot.com/4650048/diff/8001/src/cmd/prof/gopprof#newcode1320
src/cmd/prof/gopprof:1320: $output = \*TEMP;
... then you can ditch this

http://codereview.appspot.com/4650048/diff/8001/src/cmd/prof/gopprof#newcode1469
src/cmd/prof/gopprof:1469: return 0;
Add a little comment that this thing has a notable return value?

[rsc, 2011-06-21 15:27:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=09d52e36dab9 ***

gopprof: update list of memory allocators

Also import new weblist command from Google version.

R=r, bradfitz
CC=golang-dev
http://codereview.appspot.com/4650048