Issue 4438096: code review 4438096: [release-branch.r57] 5a, 6a, 8a, cc: remove old environ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4438096: code review 4438096: [release-branch.r57] 5a, 6a, 8a, cc: remove old environ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 12 months ago by rsc

Modified:
13 years, 12 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

[release-branch.r57] 5a, 6a, 8a, cc: remove old environment variables ««« CL 4445079 / f8cc81f985e5 5a, 6a, 8a, cc: remove old environment variables Uses of $INCLUDE and $NPROC are left over from Plan 9. Remove them to avoid causing confusion. R=golang-dev, r2 CC=golang-dev http://codereview.appspot.com/4445079 »»»

Patch Set 1 #

Patch Set 2 : diff -r 665c4ab05ffd https://go.googlecode.com/hg/ #

Created: 13 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -201 lines)			Patch
M	src/cmd/5a/lex.c	View	1	4 chunks	+4 lines, -49 lines	0 comments	Download
M	src/cmd/6a/lex.c	View	1	4 chunks	+4 lines, -49 lines	0 comments	Download
M	src/cmd/8a/lex.c	View	1	4 chunks	+4 lines, -49 lines	0 comments	Download
M	src/cmd/cc/lex.c	View	1	4 chunks	+4 lines, -54 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 12 months ago (2011-05-03 05:42:17 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=54b2825370c1 *** [release-branch.r57] 5a, 6a, 8a, cc: remove old environment variables ««« ...

13 years, 12 months ago (2011-05-03 05:42:21 UTC) #2

LGTM

Expand All Messages | Collapse All Messages