Issue 4445079: code review 4445079: 5a, 6a, 8a, cc: remove old environment variables

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4445079: code review 4445079: 5a, 6a, 8a, cc: remove old environment variables (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by rsc

Modified:
14 years ago

Reviewers:

CC:
golang-dev, r2

Visibility:
Public.

Description

5a, 6a, 8a, cc: remove old environment variables Uses of $INCLUDE and $NPROC are left over from Plan 9. Remove them to avoid causing confusion.

Patch Set 1 #

Patch Set 2 : diff -r 9266c53a8fc0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9266c53a8fc0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1b4f37386203 https://go.googlecode.com/hg #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -201 lines)			Patch
M	src/cmd/5a/lex.c	View	1	4 chunks	+4 lines, -49 lines	0 comments	Download
M	src/cmd/6a/lex.c	View	1	4 chunks	+4 lines, -49 lines	0 comments	Download
M	src/cmd/8a/lex.c	View	1	4 chunks	+4 lines, -49 lines	0 comments	Download
M	src/cmd/cc/lex.c	View	1	4 chunks	+4 lines, -54 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-05-02 12:39:07 UTC) #1

LGTM although it can't work with go, it's sad to see NPROC disappear. -rob

14 years ago (2011-05-02 15:23:41 UTC) #2

rsc

14 years ago (2011-05-02 15:24:34 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f8cc81f985e5 ***

5a, 6a, 8a, cc: remove old environment variables

Uses of $INCLUDE and $NPROC are left over from Plan 9.
Remove them to avoid causing confusion.

R=golang-dev, r2
CC=golang-dev
http://codereview.appspot.com/4445079

Expand All Messages | Collapse All Messages