Add predefined mandolin fretboards to lilypond.

Add predefined mandolin fretboards to lilypond.

[Carl, 2011-04-11 04:43:52]

Marc Hohl has prepared a patch for mandolin predefined fretboards.

The patch looks good to me.

Please review.

Thanks,

Carl

http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-s...
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-s...
Documentation/notation/fretted-strings.itely:1905:
@file{scm/string-tunings-init.scm} contains predefined banjo tunings.
Thanks for the catch!

[marc, 2011-04-11 08:34:34]

Am 11.04.2011 06:43, schrieb Carl.D.Sorensen@gmail.com:
> Reviewers: ,
>
> Message:
> Marc Hohl has prepared a patch for mandolin predefined fretboards.
>
> The patch looks good to me.
>
> Please review.
>
> Thanks,
>
> Carl
>
>
>
>
http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-s...

>
> File Documentation/notation/fretted-strings.itely (right):
>
>
http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-s...

>
> Documentation/notation/fretted-strings.itely:1905:
> @file{scm/string-tunings-init.scm} contains predefined banjo tunings.
> Thanks for the catch!
>
> Description:
> Add predefined mandolin fretboards to lilypond.
>
> Please review this at http://codereview.appspot.com/4384055/
Oops, I just uploaded it myself and corrected the version numbers and 
the path for inclusion
(it was \include "./predefined-..." instead of just \include 
"predefined-..." )

So please have a look at

http://codereview.appspot.com/4370054/

@Carl: sorry for messing all up...

Regards,

Marc
>
> Affected files:
>   A Documentation/included/display-predefined-mandolin-fretboards.ly
>   M Documentation/notation/fretted-strings.itely
>   M Documentation/notation/notation-appendices.itely
>   A ly/predefined-mandolin-fretboards.ly
>
>
>
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/lilypond-devel
>

[marc, 2011-04-20 06:19:13]

Am 11.04.2011 10:34, schrieb Marc Hohl:
> [...]
>
> So please have a look at
>
> http://codereview.appspot.com/4370054/
>
LGTM, anyone? ;-)

Marc