Issue 4370054: Add predefined mandolin fretboards to lilypond.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4370054: Add predefined mandolin fretboards to lilypond. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by marc

Modified:
12 years, 12 months ago

Reviewers:
Graham Percival, Graham Percival (old account), carl.d.sorensen

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Add predefined mandolin fretboards to lilypond.

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+976 lines, -2 lines)			Patch
A	Documentation/included/display-predefined-mandolin-fretboards.ly	View	1 chunk	+74 lines, -0 lines	0 comments	Download
M	Documentation/notation/fretted-strings.itely	View	4 chunks	+22 lines, -2 lines	0 comments	Download
M	Documentation/notation/notation-appendices.itely	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	ly/predefined-mandolin-fretboards.ly	View	1 chunk	+876 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Graham Percival (old account)

I can't see anything wrong, but I'm away from my desktop so I haven't tried ...

13 years ago (2011-04-20 10:47:26 UTC) #1

Carl

LGTM. If I had done it I would have defined chordShapes for the common shapes ...

13 years ago (2011-04-20 13:58:44 UTC) #2

Graham Percival (old account)

Marc: can you send me the patch so that I can push it?

12 years, 12 months ago (2011-04-25 11:24:37 UTC) #3

marc

Am 25.04.2011 13:24, schrieb percival.music.ca@gmail.com: > Marc: can you send me the patch so that ...

12 years, 12 months ago (2011-04-25 14:43:50 UTC) #4

Graham Percival

12 years, 12 months ago (2011-04-25 15:21:18 UTC) #5

On Mon, Apr 25, 2011 at 04:43:45PM +0200, Marc Hohl wrote:
> Am 25.04.2011 13:24, schrieb percival.music.ca@gmail.com:
> >Marc: can you send me the patch so that I can push it?
> >
> >http://codereview.appspot.com/4370054/
> Here it is.

thanks, pushed.

Cheers,
- Graham

Expand All Messages | Collapse All Messages