Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 4226042: code review 4226042: 5g: fix optimizer bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by rsc
Modified:
14 years, 2 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

5g: fix optimizer bug same as in issue below, never fixed on ARM changeset: 5498:3fa1372ca694 user: Ken Thompson <ken@golang.org> date: Thu May 20 17:31:28 2010 -0700 description: fix issue 798 cannot allocate an audomatic temp while real registers are allocated. there is a chance that the automatic will be allocated to one of the allocated registers. the fix is to not registerize such variables. R=rsc CC=golang-dev http://codereview.appspot.com/1202042

Patch Set 1 #

Patch Set 2 : diff -r a99cdc6c7c6d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e1e39d6b12a4 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/cmd/5g/gg.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/5g/gsubr.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/5g/reg.c View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 2 months ago (2011-02-23 18:21:38 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=de88610b0169 *** 5g: fix optimizer bug same as in issue below, never ...
14 years, 2 months ago (2011-02-23 18:21:41 UTC) #2
ken3
14 years, 2 months ago (2011-02-25 09:28:03 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b