Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(449)

Issue 1202042: code review 1202042: fix issue 798 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by ken3
Modified:
14 years, 11 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

fix issue 798 cannot allocate an audomatic temp while real registers are allocated. there is a chance that the automatic will be allocated to one of the allocated registers. the fix is to not registerize such variables.

Patch Set 1 #

Patch Set 2 : code review 1202042: fix issue 798 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M src/cmd/5g/gsubr.c View 1 chunk +6 lines, -0 lines 0 comments Download
M src/cmd/6g/gg.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/6g/gsubr.c View 2 chunks +18 lines, -0 lines 0 comments Download
M src/cmd/6g/reg.c View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/8g/gg.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/8g/gsubr.c View 2 chunks +18 lines, -0 lines 0 comments Download
M src/cmd/8g/reg.c View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/gen.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/go.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
ken3
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 11 months ago (2010-05-21 00:31:25 UTC) #1
ken3
14 years, 11 months ago (2010-05-21 00:31:30 UTC) #2
*** Submitted as http://code.google.com/p/go/source/detail?r=3fa1372ca694 ***

fix issue 798
cannot allocate an audomatic temp
while real registers are allocated.
there is a chance that the automatic
will be allocated to one of the
allocated registers. the fix is to
not registerize such variables.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1202042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b