Changes to Default spacing settings

Changes to Default spacing settings

These diff files were provided by Keith O'Hara
to set some 'improved' default spacing settings
for the 2.14 using the new spacing mechanisms

http://lists.gnu.org/archive/html/lilypond-devel/2010-11/msg00177.html

[Graham Percival (old account), 2010-11-12 14:55:28]

Nothing terribly wrong, but I'm not up to speed on spacing stuff.

http://codereview.appspot.com/3061041/diff/1/ly/engraver-init.ly
File ly/engraver-init.ly (left):

http://codereview.appspot.com/3061041/diff/1/ly/engraver-init.ly#oldcode322
ly/engraver-init.ly:322: \override StaffGrouper #'between-staff-spacing
#'stretchability = #5
Keith: why are we removing this?  Or rather, if we remove it, then what's the
value of #'stretchability ?  Does it just default to 0?

http://codereview.appspot.com/3061041/diff/1/ly/engraver-init.ly
File ly/engraver-init.ly (right):

http://codereview.appspot.com/3061041/diff/1/ly/engraver-init.ly#newcode408
ly/engraver-init.ly:408: (minimum-distance . 4.5)
James: could these keep the same indentation as the previous version?  That
makes it easier to see what's changing.  yes, I realize that this change
probably came from the diffs that Keith sent you.  Don't bother uploading a new
patchset just for this, but whenever you make the new version, please change it.

[Graham Percival (old account), 2010-11-12 15:24:21]

oops, we were missing the CC to lilypond-devel.


The patch looks generally ok to me, but I'm not up to speed on spacing stuff.

Keith: why are you removing the #'stretchability = 5 ?  What's the default value
if you remove it?

James: I suggest that the next version of the patch uses the same indentation as
the original file; that makes it much easier to see what's different.

[Keith, 2010-11-12 20:01:49]

http://codereview.appspot.com/3061041/diff/1/ly/engraver-init.ly
File ly/engraver-init.ly (left):

http://codereview.appspot.com/3061041/diff/1/ly/engraver-init.ly#oldcode322
ly/engraver-init.ly:322: \override StaffGrouper #'between-staff-spacing
#'stretchability = #5
On 2010/11/12 14:55:28, Graham Percival wrote:
> Keith: if we remove it, then what's the value of #'stretchability ?  
Still 5.  This patch changes the initialization in define-grobs, so no \override
is required, and *all* grouped staves start out half as stretchy as un-grouped
staves.

http://codereview.appspot.com/3061041/diff/1/ly/engraver-init.ly
File ly/engraver-init.ly (right):

http://codereview.appspot.com/3061041/diff/1/ly/engraver-init.ly#newcode408
ly/engraver-init.ly:408: (minimum-distance . 4.5)
Actually, I retracted the change above, after Trevor's email
<http://lists.gnu.org/archive/html/lilypond-devel/2010-11/msg00177.html>.  So
I'll send an update with old indents anyway.

[Carl, 2010-11-13 21:24:46]

I've posted a patch with the new spacing issues to reitveld.

http://codereview.appspot.com/3099041

Keith, could you please check it to make sure it's right?

Thanks,  Carl