Update spacing for Keith Ohara's suggested defaults

Update spacing for Keith Ohara's suggested defaults

[Carl, 2010-11-13 21:28:04]

Here's the new default spacing patch with the new names.

Keith, can you check it out?

THanks,

Carl

[Keith, 2010-11-13 21:59:37]

Thanks Carl.  
I marked one (non-essential) change to make the patch equivalent to its final
state after discussion at
<http://lists.gnu.org/archive/html/lilypond-devel/2010-11/msg00177.html>
Outside of that, looks good to me.

http://codereview.appspot.com/3099041/diff/1/ly/engraver-init.ly
File ly/engraver-init.ly (right):

http://codereview.appspot.com/3099041/diff/1/ly/engraver-init.ly#newcode418
ly/engraver-init.ly:418: \override VerticalAxisGroup
#'nonstaff-unrelatedstaff-spacing #'padding = #1.0
Let's do keep the 50% increase in padding, to #1.5 .

[Graham Percival (old account), 2010-11-13 22:38:36]

Looks good to me, thanks Carl!

I'll make .39 once this is applied, but let's wait 24 hours before pushing to
give people in all time zones a chance to comment.

[Carl, 2010-11-13 22:45:04]

Thanks, Keith.

Done.

Carl

http://codereview.appspot.com/3099041/diff/1/ly/engraver-init.ly
File ly/engraver-init.ly (right):

http://codereview.appspot.com/3099041/diff/1/ly/engraver-init.ly#newcode418
ly/engraver-init.ly:418: \override VerticalAxisGroup
#'nonstaff-unrelatedstaff-spacing #'padding = #1.0
On 2010/11/13 21:59:37, Keith wrote:
> Let's do keep the 50% increase in padding, to #1.5 .

Done.

[Carl, 2010-11-13 22:45:28]

On 2010/11/13 22:38:36, Graham Percival wrote:
> Looks good to me, thanks Carl!
> 
> I'll make .39 once this is applied, but let's wait 24 hours before pushing to
> give people in all time zones a chance to comment.

OK, I'll wait till tomorrow night.

Carl

[Patrick McCarty, 2010-11-13 22:49:42]

Hi Carl,

Just one tiny style nitpick below.  Otherwise, looks fine.

Thanks,
Patrick

http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly
File ly/paper-defaults-init.ly (right):

http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly#new...
ly/paper-defaults-init.ly:60: system-system-spacing = #'((space . 12)
(minimum-distance . 8) (padding . 1)(stretchability . 60))
There is a space missing between "(padding . 1)" and "(stretchability . 60)"

[Carl, 2010-11-13 22:58:38]

Thanks, Patrick.

Carl

http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly
File ly/paper-defaults-init.ly (right):

http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly#new...
ly/paper-defaults-init.ly:60: system-system-spacing = #'((space . 12)
(minimum-distance . 8) (padding . 1)(stretchability . 60))
On 2010/11/13 22:49:43, Patrick McCarty wrote:
> There is a space missing between "(padding . 1)" and "(stretchability . 60)"

Good catch!  It was right at the line-wrap on the original file, so I couldn't
see it.

Done.

[Carl, 2010-11-15 00:48:28]

Pushed to git.

Thanks,

Carl