Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 248041: * Unify fetaDynamic and fetaNumber into one fetaText encoding (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by hanwenn
Modified:
13 years, 2 months ago
Reviewers:
Patrick McCarty
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

* Unify fetaDynamic and fetaNumber into one fetaText encoding * Load fetaText through the emmentaler OTF font.

Patch Set 1 #

Patch Set 2 : change fontname to include design size #

Patch Set 3 : 2nd try to upload #

Patch Set 4 : oops - inverted the patch before #

Patch Set 5 : 2nd try at uploading #

Patch Set 6 : ignore previous upload, got issues mixed up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -32 lines) Patch
M Documentation/notation/changing-defaults.itely View 2 3 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/text.itely View 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M lily/font-config.cc View 2 3 1 chunk +0 lines, -1 line 0 comments Download
M lily/time-signature.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download
M python/convertrules.py View 2 3 1 chunk +5 lines, -0 lines 0 comments Download
scm/define-grob-properties.scm View 2 3 5 1 chunk +1 line, -1 line 0 comments Download
scm/define-grobs.scm View 2 3 7 chunks +7 lines, -7 lines 0 comments Download
scm/define-markup-commands.scm View 2 3 4 chunks +4 lines, -4 lines 0 comments Download
scm/font.scm View 1 2 3 5 7 chunks +14 lines, -12 lines 0 comments Download
M scripts/build/gen-emmentaler-scripts.py View 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Patrick McCarty
Han-Wen, I'm can't see this patch in its entirety, because I think some of the ...
14 years, 1 month ago (2010-03-05 09:15:11 UTC) #1
hanwenn
Hey - can you look again, in addition to failing the upload I also inverted ...
14 years, 1 month ago (2010-03-05 15:13:25 UTC) #2
Patrick McCarty
LGTM. Since this commit removes the need for the feta-alphabet Type-1 fonts, we no longer ...
14 years, 1 month ago (2010-03-06 21:25:28 UTC) #3
Patrick McCarty
14 years, 1 month ago (2010-03-06 21:39:41 UTC) #4
I just realized that this breaks the SVG backend, but I have a patch for that,
so you don't need to worry about it.

Thanks,
Patrick


On 2010/03/06 21:25:28, Patrick McCarty wrote:
> LGTM.
> 
> Since this commit removes the need for the feta-alphabet Type-1 fonts, we no
> longer need to distribute them, but that's something that can be done at a
later
> time.
> 
> Thanks,
> Patrick
> 
> 
> On 2010/03/05 15:13:25, hanwenn wrote:
> > Hey - can you look again,
> > 
> > in addition to failing the upload I also inverted the patch.
> > 
> > The patch is against the branch tip where I added support for music
> > glyphs from Gonville.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b