Han-Wen, I'm can't see this patch in its entirety, because I think some of the ...
14 years, 2 months ago
(2010-03-05 09:15:11 UTC)
#1
Han-Wen,
I'm can't see this patch in its entirety, because I think some of the files
failed to upload to Rietveld.
Can you try reuploading your patch, even to a new issue if necessary?
Thanks,
Patrick
Hey - can you look again, in addition to failing the upload I also inverted ...
14 years, 2 months ago
(2010-03-05 15:13:25 UTC)
#2
Hey - can you look again,
in addition to failing the upload I also inverted the patch.
The patch is against the branch tip where I added support for music
glyphs from Gonville.
On Fri, Mar 5, 2010 at 6:15 AM, <pnorcks@gmail.com> wrote:
> Han-Wen,
>
> I'm can't see this patch in its entirety, because I think some of the
> files failed to upload to Rietveld.
>
> Can you try reuploading your patch, even to a new issue if necessary?
>
> Thanks,
> Patrick
>
> http://codereview.appspot.com/248041/show
>
--
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen
LGTM. Since this commit removes the need for the feta-alphabet Type-1 fonts, we no longer ...
14 years, 2 months ago
(2010-03-06 21:25:28 UTC)
#3
LGTM.
Since this commit removes the need for the feta-alphabet Type-1 fonts, we no
longer need to distribute them, but that's something that can be done at a later
time.
Thanks,
Patrick
On 2010/03/05 15:13:25, hanwenn wrote:
> Hey - can you look again,
>
> in addition to failing the upload I also inverted the patch.
>
> The patch is against the branch tip where I added support for music
> glyphs from Gonville.
I just realized that this breaks the SVG backend, but I have a patch for ...
14 years, 2 months ago
(2010-03-06 21:39:41 UTC)
#4
I just realized that this breaks the SVG backend, but I have a patch for that,
so you don't need to worry about it.
Thanks,
Patrick
On 2010/03/06 21:25:28, Patrick McCarty wrote:
> LGTM.
>
> Since this commit removes the need for the feta-alphabet Type-1 fonts, we no
> longer need to distribute them, but that's something that can be done at a
later
> time.
>
> Thanks,
> Patrick
>
>
> On 2010/03/05 15:13:25, hanwenn wrote:
> > Hey - can you look again,
> >
> > in addition to failing the upload I also inverted the patch.
> >
> > The patch is against the branch tip where I added support for music
> > glyphs from Gonville.
Issue 248041: * Unify fetaDynamic and fetaNumber into one fetaText encoding
(Closed)
Created 14 years, 2 months ago by hanwenn
Modified 13 years, 3 months ago
Reviewers: Patrick McCarty
Base URL:
Comments: 0