Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(187)

Issue 183153: Add builder scripts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by agl1
Modified:
15 years, 4 months ago
Reviewers:
r
CC:
rsc, golang-dev
Visibility:
Public.

Description

Add builder scripts. These are the scripts behind godashboard.appspot.com. Nothing is particularly beautiful about it, but it does run. I still need to add support for per-builder keys and for running the benchmarks.

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review 183153: Add builder scripts. #

Total comments: 7

Patch Set 3 : code review 183153: Add builder scripts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+697 lines, -0 lines) Patch
A misc/dashboard/README View 1 chunk +33 lines, -0 lines 0 comments Download
A misc/dashboard/buildcontrol.py View 1 1 chunk +193 lines, -0 lines 0 comments Download
A misc/dashboard/builder.sh View 1 1 chunk +64 lines, -0 lines 0 comments Download
A misc/dashboard/godashboard/_multiprocessing.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
A misc/dashboard/godashboard/app.yaml View 1 chunk +8 lines, -0 lines 0 comments Download
A misc/dashboard/godashboard/gobuild.py View 1 1 chunk +285 lines, -0 lines 0 comments Download
A misc/dashboard/godashboard/index.yaml View 1 chunk +16 lines, -0 lines 0 comments Download
A misc/dashboard/godashboard/key.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
A misc/dashboard/godashboard/main.html View 1 2 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 7
agl1
15 years, 4 months ago (2010-01-08 02:24:58 UTC) #1
rsc
LGTM please add the usual copyright notice to *.py, *.sh http://codereview.appspot.com/183153/diff/1/3 File misc/dashboard/buildcontrol.py (right): http://codereview.appspot.com/183153/diff/1/3#newcode107 ...
15 years, 4 months ago (2010-01-08 02:30:55 UTC) #2
agl1
http://codereview.appspot.com/183153/diff/1/3 File misc/dashboard/buildcontrol.py (right): http://codereview.appspot.com/183153/diff/1/3#newcode107 misc/dashboard/buildcontrol.py:107: if c is None: On 2010/01/08 02:30:55, rsc wrote: ...
15 years, 4 months ago (2010-01-08 02:45:03 UTC) #3
agl1
*** Submitted as http://code.google.com/p/go/source/detail?r=18f50ef973de *** Add builder scripts. These are the scripts behind godashboard.appspot.com. Nothing ...
15 years, 4 months ago (2010-01-08 02:45:44 UTC) #4
r2
i have a bunch of comments On Jan 8, 2010, at 1:30 PM, rsc@golang.org wrote: ...
15 years, 4 months ago (2010-01-08 02:46:19 UTC) #5
r
LGTM http://codereview.appspot.com/183153/diff/1001/1002 File misc/dashboard/README (right): http://codereview.appspot.com/183153/diff/1001/1002#newcode1 misc/dashboard/README:1: The files in this directory constitute the continuous ...
15 years, 4 months ago (2010-01-08 02:47:05 UTC) #6
agl1
15 years, 4 months ago (2010-01-08 02:59:58 UTC) #7
On 2010/01/08 02:47:05, r wrote:
> LGTM

Sorry Rob, didn't expect anyone else to care. Addressed in
http://codereview.appspot.com/183154 which I'll leave open until tomorrow in
case anybody else has comments.

Cheers
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b