Issue 183154: Address Rob's comments on issue 183153

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 183154: Address Rob's comments on issue 183153 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by agl1

Modified:
15 years, 3 months ago

Reviewers:
r

CC:
golang-dev

Visibility:
Public.

Description

Address Rob's comments on issue 183153

Patch Set 1 #

Total comments: 1

Patch Set 2 : code review 183154: Address Rob's comments on issue 183153 #

Patch Set 3 : code review 183154: Address Rob's comments on issue 183153 #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -8 lines)			Patch
M	misc/dashboard/README	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	misc/dashboard/builder.sh	View	1	3 chunks	+12 lines, -5 lines	0 comments	Download
M	misc/dashboard/godashboard/gobuild.py	View	1	4 chunks	+70 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM http://codereview.appspot.com/183154/diff/1/3 File misc/dashboard/builder.sh (right): http://codereview.appspot.com/183154/diff/1/3#newcode8 misc/dashboard/builder.sh:8: echo $0 $1 1>2 s/0/0:/

15 years, 4 months ago (2010-01-08 03:01:18 UTC) #1

*** Abandoned ***

Expand All Messages | Collapse All Messages