Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(565)

Issue 118000043: code review 118000043: test: add test for confusion with dot imports (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by iant
Modified:
9 years, 8 months ago
Reviewers:
bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

test: add test for confusion with dot imports The gccgo compiler would fail this test. The fix for gccgo is http://codereview.appspot.com/116960043 .

Patch Set 1 #

Patch Set 2 : diff -r d5c083552430 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
A test/fixedbugs/bug488.go View 1 chunk +12 lines, -0 lines 0 comments Download
A test/fixedbugs/bug488.dir/a.go View 1 chunk +7 lines, -0 lines 0 comments Download
A test/fixedbugs/bug488.dir/b.go View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
iant
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2014-07-20 14:50:00 UTC) #1
bradfitz
LGTM On Jul 20, 2014 9:50 AM, <iant@golang.org> wrote: > Reviewers: golang-codereviews, > > Message: ...
9 years, 8 months ago (2014-07-20 16:55:56 UTC) #2
iant
9 years, 8 months ago (2014-07-20 17:28:56 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=7ef3da0152de ***

test: add test for confusion with dot imports

The gccgo compiler would fail this test.  The fix for gccgo is
http://codereview.appspot.com/116960043 .

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/118000043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b