Issue 986042: [PATCH] Consolidate the description of volatile operations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 986042: [PATCH] Consolidate the description of volatile operations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Jeffrey Yasskin

Modified:
14 years ago

Reviewers:
llvm-commits, gohman

CC:
chandlerc1, resistor

Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Description

Now that some of the intrinsics have volatile semantics, in addition to load and store, it seems useful to consolidate the definition of "volatile" and have all the uses refer to one place. This will also be useful as we add atomic operations since they also need optional volatile semantics.

Patch Set 1 #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -14 lines)			Patch
	M	docs/LangRef.html	View		7 chunks	+37 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Jeffrey Yasskin

Please take a look. The patch file is at http://codereview.appspot.com/download/issue986042_1.diff until I make changes in ...

14 years ago (2010-04-25 21:23:18 UTC) #1

gohman

This looks good to me. There are some tricky issues with volatile not covered here, ...

14 years ago (2010-04-26 21:15:19 UTC) #2

Jeffrey Yasskin (google)

14 years ago (2010-04-26 21:23:12 UTC) #3

Thanks!

On Mon, Apr 26, 2010 at 2:15 PM,  <gohman@apple.com> wrote:
> This looks good to me.  There are some tricky issues with volatile not
> covered here, but they weren't covered by the original text either :-).
>
> http://codereview.appspot.com/986042/show

Expand All Messages | Collapse All Messages