Issue 970046: code review 970046: goprotobuf: make the generator a package, with the main

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 970046: code review 970046: goprotobuf: make the generator a package, with the main (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by r

Modified:
15 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

goprotobuf: make the generator a package, with the main program a separate file. also introduce the hooks for a plugin (really a plugin for this plugin) to enable add-on generators for things like RPC.

Patch Set 1 #

Patch Set 2 : code review 970046: goprotobuf: make the generator a package, with the main #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1085 lines, -944 lines)			Patch
M	compiler/Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/descriptor/Makefile	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	compiler/generator/Makefile	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
A	compiler/generator/generator.go	View	1	1 chunk	+1030 lines, -0 lines	0 comments	Download
M	compiler/main.go	View		2 chunks	+10 lines, -943 lines	0 comments	Download
M	compiler/plugin/Makefile	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 3 months ago (2010-04-30 20:27:01 UTC) #1

15 years, 3 months ago (2010-04-30 22:19:29 UTC) #3

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=39b0931353f8 ***

goprotobuf: make the generator a package, with the main
program a separate file.  also introduce the hooks for a plugin
(really a plugin for this plugin) to enable add-on generators for
things like RPC.

R=rsc
CC=golang-dev
http://codereview.appspot.com/970046

Expand All Messages | Collapse All Messages