code review 965045: codelab/index.html "os" needs to be imported because os...

codelab/index.html "os" needs to be imported because os.Error is used almost immediately

Also, calling fmt, ioutil and os "builtin" is probably confusing.

[aam, 2010-04-29 03:51:02]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[aam, 2010-04-29 03:58:17]

Hello adg (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2010-04-29 04:06:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=4a2a6498cb84 ***

codelab/index.html "os" needs to be imported because os.Error is used almost
immediately

Also, calling fmt, ioutil and os "builtin" is probably confusing.

R=adg
CC=golang-dev
http://codereview.appspot.com/965045

Committer: Andrew Gerrand <adg@golang.org>

[adg, 2010-04-29 04:06:48]

LGTM

Thanks.

On 29 April 2010 13:51,  <mirtchovski@gmail.com> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> codelab/index.html "os" needs to be imported because os.Error is used
> almost immediately
>
> Also, calling fmt, ioutil and os "builtin" is probably confusing.
>
> Please review this at http://codereview.appspot.com/965045/show
>
> Affected files:
>  M doc/codelab/wiki/index.html
>
>
> Index: doc/codelab/wiki/index.html
> ===================================================================
> --- a/doc/codelab/wiki/index.html
> +++ b/doc/codelab/wiki/index.html
> @@ -58,11 +58,12 @@
>  import (
>        "fmt"
>        "io/ioutil"
> +       "os"
>  )
>  </pre>
>
>  <p>
> -Both <code>fmt</code> and <code>ioutil</code> are built-in packages that
> +<code>Fmt</code>, <code>ioutil</code> and <code>os</code> are standard
> library packages that
>  we'll be using. Later, as we implement additional functionality, we will
> add
>  more packages to this <code>import</code> declaration.
>  </p>
>
>
>

[aam, 2010-04-29 04:13:09]

Hello golang-dev@googlegroups.com (cc: adg),

Please take another look.

[aam, 2010-04-29 04:13:44]

argh, not quick enough. after seeing a few typos i ran the whole thing
through a spellchecker, which took some time :)

[adg, 2010-04-29 04:15:24]

Oh, damn. Send through another CL please. =)

On 29 April 2010 14:13, andrey mirtchovski <mirtchovski@gmail.com> wrote:
> argh, not quick enough. after seeing a few typos i ran the whole thing
> through a spellchecker, which took some time :)
>