Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(200)

Issue 96084: stats: make more stats work in Linux (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by fhs
Modified:
15 years, 5 months ago
Reviewers:
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : update patch as suggested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -7 lines) Patch
M man/man1/stats.1 View 1 chunk +5 lines, -0 lines 0 comments Download
M src/cmd/auxstats/Linux.c View 1 8 chunks +66 lines, -6 lines 0 comments Download
M src/cmd/draw/stats.c View 4 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7
fhs
15 years, 5 months ago (2009-07-21 09:23:27 UTC) #1
russcox_gmail.com
Thanks for adding this. A few tiny issues. http://codereview.appspot.com/96084/diff/1/3 File src/cmd/auxstats/Linux.c (right): http://codereview.appspot.com/96084/diff/1/3#newcode93 Line 93: ...
15 years, 5 months ago (2009-07-25 18:35:51 UTC) #2
fhs
Nope, there was no compiler warning, but that's understandable since sfree was used in only ...
15 years, 5 months ago (2009-07-25 20:50:29 UTC) #3
russcox_gmail.com
codebot: apply stats: make more stats work in Linux
15 years, 5 months ago (2009-08-08 20:40:34 UTC) #4
old.codebot
# codebot: apply codebot error: unknown full name for fhs <fshahriar@gmail.com> fhs, please add a ...
15 years, 5 months ago (2009-08-08 20:40:41 UTC) #5
russcox_gmail.com
i took care of codebot's whining codebot: apply stats: make more stats work in Linux
15 years, 5 months ago (2009-08-08 20:42:01 UTC) #6
old.codebot
15 years, 5 months ago (2009-08-08 20:43:07 UTC) #7
# codebot: apply

applied.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b