Issue 9426044: side-position-interface: use real positions of cross-staff grobs; issue 3363

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9426044: side-position-interface: use real positions of cross-staff grobs; issue 3363 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by Keith

Modified:
10 years, 8 months ago

Reviewers:
MikeSol, janek

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

side-position-interface: cross-staff items, issue 3363 Grobs that are not cross-staff are placed before staff-spacing, so they may not force placement of cross-staff grobs. When cross-staff items are placed around the spaced staves, let them side-position using the final, not 'pure', information.

Patch Set 1 #

Patch Set 2 : include a fix for stem direction, issue 3385 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -25 lines)			Patch
M	input/regression/slur-cross-staff-beam.ly	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download
M	lily/side-position-interface.cc	View	1	2 chunks	+15 lines, -19 lines	0 comments	Download
M	scm/define-grob-properties.scm	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

MikeSol

LGTM - just make sure to check this against the dynamics-avoid-cross-staff-stem regtests.

10 years, 8 months ago (2013-08-16 06:59:46 UTC) #1

LGTM. Nice, clear description!
thanks,
Janek

Expand All Messages | Collapse All Messages