Issue 9196046: QuickLattice

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9196046: QuickLattice

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by ideasman42

Modified:
11 years ago

Reviewers:
bf-codereview

CC:
genelkullan_plecxus.com

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

More Reviews

Description

QuickLattice

Patch Set 1 #

Total comments: 9

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	release/scripts/addons_contrib/mesh_easylattice.py	View		1 chunk	+0 lines, -4 lines	9 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ideasman42

11 years ago (2013-05-12 15:04:46 UTC) #2

initial review.

https://codereview.appspot.com/9196046/diff/1/release/scripts/addons_contrib/...
File release/scripts/addons_contrib/mesh_easylattice.py (right):

https://codereview.appspot.com/9196046/diff/1/release/scripts/addons_contrib/...
release/scripts/addons_contrib/mesh_easylattice.py:1: bl_info = {
missing GPL2+ license header.

https://codereview.appspot.com/9196046/diff/1/release/scripts/addons_contrib/...
release/scripts/addons_contrib/mesh_easylattice.py:26:
bpy.ops.object.modifier_remove( modifier = mod.name )
you can remove modifiers like this
obj.modifiers.remove(mod)

https://codereview.appspot.com/9196046/diff/1/release/scripts/addons_contrib/...
release/scripts/addons_contrib/mesh_easylattice.py:32: if "LatticeEasytTemp" in
ob.name:
using names as ID's like this is a bit weak, could tag with a property or add to
a group.

https://codereview.appspot.com/9196046/diff/1/release/scripts/addons_contrib/...
release/scripts/addons_contrib/mesh_easylattice.py:34: bpy.ops.object.delete(
use_global = False )
you can do...
scene.objects.unlink(obj)

better then calling operator

https://codereview.appspot.com/9196046/diff/1/release/scripts/addons_contrib/...
release/scripts/addons_contrib/mesh_easylattice.py:41: loc = getTransformations(
obj )[0]
should only be called once

https://codereview.appspot.com/9196046/diff/1/release/scripts/addons_contrib/...
release/scripts/addons_contrib/mesh_easylattice.py:82: #    points = [
commenting our large blocks of code, use ''' is nicer (less noisy diffs)

https://codereview.appspot.com/9196046/diff/1/release/scripts/addons_contrib/...
release/scripts/addons_contrib/mesh_easylattice.py:99:
bpy.ops.object.editmode_toggle()
could add editmode support through bmesh api.

https://codereview.appspot.com/9196046/diff/1/release/scripts/addons_contrib/...
release/scripts/addons_contrib/mesh_easylattice.py:135: minx =
selvertsarray[0].co.x
nicer to do...
minx, miny, minz = selvertsarray[0].co

https://codereview.appspot.com/9196046/diff/1/release/scripts/addons_contrib/...
release/scripts/addons_contrib/mesh_easylattice.py:181: #     middle = mat_world
* mathutils.Vector((x_sum, y_sum, z_sum))/float(c)
no need to convert to float() with python3

Expand All Messages | Collapse All Messages