Hi Boris, LGTM, apart from a few formatting nitpicks, though it could be simpler using the conditional operator, i.e., + SCM length_data = me->get_property_data ("length"); + Real len + = scm_to_double (scm_is_number (length_data) + ? length_data + : calc_length (smob)) * ss / 2; I suppose we should have a regtest too. Cheers, Neil http://codereview.appspot.com/908045/diff/1/2 File lily/stem.cc (right): http://codereview.appspot.com/908045/diff/1/2#newcode260 lily/stem.cc:260: if (scm_is_number(user_set_len_scm)) scm_is_number ( http://codereview.appspot.com/908045/diff/1/2#newcode261 lily/stem.cc:261: { remove { } http://codereview.appspot.com/908045/diff/1/2#newcode263 lily/stem.cc:263: } else { newline for else remove { }
http://codereview.appspot.com/908045/diff/1/2 File lily/stem.cc (right): http://codereview.appspot.com/908045/diff/1/2#newcode260 lily/stem.cc:260: if (scm_is_number(user_set_len_scm)) On 2010/04/18 21:06:15, Neil Puttock wrote: > scm_is_number ( Done. http://codereview.appspot.com/908045/diff/1/2#newcode261 lily/stem.cc:261: { On 2010/04/18 21:06:15, Neil Puttock wrote: > remove { } Done. http://codereview.appspot.com/908045/diff/1/2#newcode263 lily/stem.cc:263: } else { On 2010/04/18 21:06:15, Neil Puttock wrote: > newline for else > > remove { } Done.