Issue 908045: Pure-height of stems does not accurately estimate height (Bug 1056)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 908045: Pure-height of stems does not accurately estimate height (Bug 1056)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Boris Shingarov

Modified:
9 years, 7 months ago

Reviewers:
Neil Puttock

Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Better code formatting #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	lily/stem.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Neil Puttock

Hi Boris, LGTM, apart from a few formatting nitpicks, though it could be simpler using ...

14 years ago (2010-04-18 21:06:15 UTC) #1

Boris Shingarov

14 years ago (2010-04-21 00:52:06 UTC) #2

http://codereview.appspot.com/908045/diff/1/2
File lily/stem.cc (right):

http://codereview.appspot.com/908045/diff/1/2#newcode260
lily/stem.cc:260: if (scm_is_number(user_set_len_scm))
On 2010/04/18 21:06:15, Neil Puttock wrote:
> scm_is_number (

Done.

http://codereview.appspot.com/908045/diff/1/2#newcode261
lily/stem.cc:261: {
On 2010/04/18 21:06:15, Neil Puttock wrote:
> remove { }

Done.

http://codereview.appspot.com/908045/diff/1/2#newcode263
lily/stem.cc:263: } else {
On 2010/04/18 21:06:15, Neil Puttock wrote:
> newline for else
> 
> remove { }

Done.

Expand All Messages | Collapse All Messages