Issue 902042: code review 902042: rename os.Dir to os.FileInfo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 902042: code review 902042: rename os.Dir to os.FileInfo (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by r

Modified:
15 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

rename os.Dir to os.FileInfo

Patch Set 1 #

Patch Set 2 : code review 902042: rename os.Dir to os.FileInfo #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+143 lines, -142 lines)			Patch
M	src/cmd/godoc/godoc.go	View	3 chunks	+11 lines, -11 lines	0 comments	Download
M	src/cmd/godoc/index.go	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/cmd/gofmt/gofmt.go	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/go/parser/interface.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/go/parser/parser_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/io/ioutil/ioutil.go	View	3 chunks	+13 lines, -13 lines	0 comments	Download
M	src/pkg/os/file.go	View	3 chunks	+25 lines, -24 lines	0 comments	Download
M	src/pkg/os/stat_darwin.go	View	1 chunk	+17 lines, -17 lines	0 comments	Download
M	src/pkg/os/stat_linux.go	View	1 chunk	+17 lines, -17 lines	0 comments	Download
M	src/pkg/os/stat_mingw.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/os/stat_nacl.go	View	1 chunk	+17 lines, -17 lines	0 comments	Download
M	src/pkg/os/types.go	View	2 chunks	+17 lines, -17 lines	0 comments	Download
M	src/pkg/path/path.go	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/pkg/path/path_test.go	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 3 months ago (2010-04-08 21:34:48 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=82bb840119a6 *** rename os.Dir to os.FileInfo R=rsc CC=golang-dev http://codereview.appspot.com/902042

15 years, 3 months ago (2010-04-09 18:36:46 UTC) #2

LGTM

Expand All Messages | Collapse All Messages