code review 897042: Create pkg/os/sys_bsd for code used by Darwin and other...

Create pkg/os/sys_bsd for code used by Darwin and other *BSDs

This CL is similar in spirit to:

http://codereview.appspot.com/751041/show

and is offered for the same reasons:

1. reduce existing code duplication between the Darwin (OS X)
   and FreeBSD ports
2. eliminate the need to duplicate the code a third time for
   the in-progress NetSBD port
3. As more functions are added, the need only be added once,
   not once for each *BSD based OS that Go is ported to

The payback is not as large immediately as for 751041 as only
one function is shared and the Makefile becomes more complex.

(If there is a simpler way to achieve the same result in the
Makefile, please let me know and I will revise the CL. I did
look for simpler methods, but perhaps someone with more GNU
make expertise will know a useful trick or idiom.)

[rsc1, 2010-04-13 23:29:26]

Thanks.

Let's delete the empty files.

Add sys_whatever.go to the appropriate
lists in the Makefile and delete sys_$(GOOS).go
from the GOFILES list.

If we need to re-split the functions we can
reintroduce the files then.

[giles, 2010-04-23 05:26:06]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[giles, 2010-04-23 05:26:31]

rsc@google.com wrote:

> Let's delete the empty files.

Done.

> Add sys_whatever.go to the appropriate
> lists in the Makefile and delete sys_$(GOOS).go
> from the GOFILES list.

Done: sys_whatever.go is still sys_bsd.go; I don't think
it should be sys_unix.go as file_unix.go has recently been
created and includes Linux, which this change doesn't.

Of course, if you'd prefer sys_whatever.go to sys_bsd.go,
I'd be happy with that too. :-)

> http://codereview.appspot.com/897042/show

Have tested on Darwin (386 and amd64) and FreeBSD (386) which
are all the platforms I have access to just now.  Per the test
suite nothing additional is broken....

PTAL mail following shortly.

Regards,

Giles

[rsc1, 2010-04-27 06:01:20]

LGTM

[rsc, 2010-04-27 06:01:35]

*** Submitted as http://code.google.com/p/go/source/detail?r=232302a32413 ***

os: create sys_bsd.go

R=rsc
CC=golang-dev
http://codereview.appspot.com/897042

Committer: Russ Cox <rsc@golang.org>