code review 894041: Freetype-Go: Implement cubic splines; rename MoveN to AddN.

Freetype-Go: Implement cubic splines; rename MoveN to AddN.

[nigeltao, 2010-04-06 00:23:47]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com, r@golang.org),

I'd like you to review this change.

[rsc1, 2010-04-06 05:17:52]

LGTM

http://codereview.appspot.com/894041/diff/5001/6002
File freetype/raster/raster.go (right):

http://codereview.appspot.com/894041/diff/5001/6002#newcode360
freetype/raster/raster.go:360: midx := (p[0].X + 2*p[1].X + p[2].X) / 4
This changed from r.a to p[0] (e.g. pstack[2] to pstack[2*i])
I assume that was intentional - it looks like 
a reasonable bug fix - but wanted to point it out just in case.

[nigeltao, 2010-04-06 11:26:55]

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=ee04355173c8 ***

Freetype-Go: Implement cubic splines; rename MoveN to AddN.

R=rsc
CC=golang-dev, r
http://codereview.appspot.com/894041

[nigeltao, 2010-04-06 11:31:40]

http://codereview.appspot.com/894041/diff/5001/6002
File freetype/raster/raster.go (right):

http://codereview.appspot.com/894041/diff/5001/6002#newcode360
freetype/raster/raster.go:360: midx := (p[0].X + 2*p[1].X + p[2].X) / 4
On 2010/04/06 05:17:52, rsc1 wrote:
> This changed from r.a to p[0] (e.g. pstack[2] to pstack[2*i])
> I assume that was intentional - it looks like 
> a reasonable bug fix - but wanted to point it out just in case.
> 

Yes, this was intentional. It wasn't a bug fix so much as that I think it's
easier to understand and more symmetrical this way (p[2]) than the C Freetype
implementation's way (r.a). They're both the same value, being the current pen
position. r.a is set at the last line of Start or Add1.