Issue 891048: code review 891048: xml: update documentation to match current coding style

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 891048: code review 891048: xml: update documentation to match current coding style (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by cw

Modified:
15 years, 3 months ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

xml: update documentation to match current coding style

Patch Set 2 : code review 891048: xml: update documentation to match current coding style #

Total comments: 2

Patch Set 3 : code review 891048: xml: update documentation to match current coding style #

Patch Set 4 : code review 891048: xml: update documentation to match current coding style #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
	M	src/pkg/xml/read.go	View	1 2	2 chunks	+13 lines, -14 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello rsc, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 3 months ago (2010-04-11 06:25:29 UTC) #1

http://codereview.appspot.com/891048/diff/2001/3001 File src/pkg/xml/read.go (right): http://codereview.appspot.com/891048/diff/2001/3001#newcode41 src/pkg/xml/read.go:41: // } removing the semicolons is fine but you ...

15 years, 3 months ago (2010-04-11 17:23:47 UTC) #2

Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.

15 years, 3 months ago (2010-04-12 03:59:56 UTC) #3

15 years, 3 months ago (2010-04-12 17:28:53 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=e1b92ac10434 ***

xml: update documentation to match current coding style

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/891048

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages