Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 879046: code review 879046: Add E_ prefixes to *all* extension descriptors to avoid... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by dsymonds
Modified:
15 years, 4 months ago
Reviewers:
CC:
r
Visibility:
Public.

Description

Add E_ prefixes to *all* extension descriptors to avoid namespace collisions.

Patch Set 1 #

Patch Set 2 : code review 879046: Add E_ prefixes to *all* extension descriptors to avoid... #

Patch Set 3 : code review 879046: Add E_ prefixes to *all* extension descriptors to avoid... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M compiler/main.go View 2 chunks +4 lines, -4 lines 0 comments Download
M compiler/testdata/extension_test.go View 5 chunks +10 lines, -11 lines 0 comments Download
M compiler/testdata/test.pb.go.golden View 1 chunk +1 line, -1 line 0 comments Download
M proto/lib.go View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dsymonds
Hello r, I'd like you to review this change.
15 years, 4 months ago (2010-04-08 05:11:42 UTC) #1
r
LGTM you said it was waiting for my review but I saw no mail about ...
15 years, 4 months ago (2010-04-10 15:42:58 UTC) #2
dsymonds
15 years, 4 months ago (2010-04-11 00:02:56 UTC) #3
*** Submitted as 2af146fd77f1 ***

Add E_ prefixes to *all* extension descriptors to avoid namespace collisions.

R=r
http://codereview.appspot.com/879046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b