Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1366)

Issue 868046: code review 868046: acme: fix off by one in editcmd, pointer comparison in ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by rsc
Modified:
14 years, 6 months ago
Reviewers:
CC:
r
Visibility:
Public.

Description

acme: fix off by one in editcmd, pointer comparison in getch, nextc

Patch Set 1 #

Patch Set 2 : code review 868046: acme: fix off by one in editcmd, pointer comparison in ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/cmd/acme/edit.c View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r, I'd like you to review this change.
14 years, 6 months ago (2010-07-14 18:08:37 UTC) #1
rsc
*** Submitted as 9eba897e5aee *** acme: fix off by one in editcmd, pointer comparison in ...
14 years, 6 months ago (2010-07-14 18:09:19 UTC) #2
r2
14 years, 6 months ago (2010-07-14 18:11:43 UTC) #3
LGTM

bizarre

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b