code review 864042: tabwriter: use panic/recover to handle errors

tabwriter: use panic/recover to handle errors

[gri, 2010-03-31 21:18:28]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-03-31 21:36:36]

http://codereview.appspot.com/864042/diff/6001/7001
File src/pkg/tabwriter/tabwriter.go (right):

http://codereview.appspot.com/864042/diff/6001/7001#newcode460
src/pkg/tabwriter/tabwriter.go:460: if e, ok := e.(os.Error); ok {
won't this always succeed?

[gri, 2010-03-31 21:41:16]

http://codereview.appspot.com/864042/diff/6001/7001
File src/pkg/tabwriter/tabwriter.go (right):

http://codereview.appspot.com/864042/diff/6001/7001#newcode460
src/pkg/tabwriter/tabwriter.go:460: if e, ok := e.(os.Error); ok {
On 2010/03/31 21:36:36, r wrote:
> won't this always succeed?

No, there are some explicit panic calls with non-os.Error arguments, but in
general there may be genuine other (runtime) panics due to bugs. One could just
let the conversion fail, but this seems a bit cleaner to me.

[gri, 2010-03-31 21:47:14]

On Wed, Mar 31, 2010 at 2:41 PM, <gri@golang.org> wrote:

>
> http://codereview.appspot.com/864042/diff/6001/7001
> File src/pkg/tabwriter/tabwriter.go (right):
>
> http://codereview.appspot.com/864042/diff/6001/7001#newcode460
> src/pkg/tabwriter/tabwriter.go:460: if e, ok := e.(os.Error); ok {
> On 2010/03/31 21:36:36, r wrote:
>
>> won't this always succeed?
>>
>
> No, there are some explicit panic calls with non-os.Error arguments, but
> in general there may be genuine other (runtime) panics due to bugs. One
> could just let the conversion fail, but this seems a bit cleaner to me.
>
>
> http://codereview.appspot.com/864042/show
>

never mind - you're right

[gri, 2010-03-31 22:03:03]

Hello rsc, r (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-03-31 22:28:37]

http://codereview.appspot.com/864042/diff/14001/15001
File src/pkg/tabwriter/tabwriter.go (right):

http://codereview.appspot.com/864042/diff/14001/15001#newcode226
src/pkg/tabwriter/tabwriter.go:226: type osError os.Error
Anything that satisfies os.Error (an interface) also satisfies osError

[gri, 2010-03-31 22:53:28]

PTAL

On Wed, Mar 31, 2010 at 3:28 PM, <rsc@google.com> wrote:

>
> http://codereview.appspot.com/864042/diff/14001/15001
>
> File src/pkg/tabwriter/tabwriter.go (right):
>
> http://codereview.appspot.com/864042/diff/14001/15001#newcode226
> src/pkg/tabwriter/tabwriter.go:226: type osError os.Error
> Anything that satisfies os.Error (an interface) also satisfies osError
>
>
> http://codereview.appspot.com/864042/show
>

[rsc1, 2010-03-31 22:56:57]

LGTM

[gri, 2010-03-31 23:01:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=e0d39840763f ***

tabwriter: use panic/recover to handle errors

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/864042