Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(841)

Issue 8580044: [google] Avoid warning when unused attribute applied to C++ member variables

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by tejohnson
Modified:
9 years, 6 months ago
Reviewers:
davidxl
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_7/gcc/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M c-family/c-common.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
tejohnson
This patch is pending on trunk, but I would like to get this into google ...
10 years, 11 months ago (2013-04-09 18:01:59 UTC) #1
davidxl
10 years, 11 months ago (2013-04-09 19:32:30 UTC) #2
Ok -- there are legitimate use cases for this.

David

On Tue, Apr 9, 2013 at 11:01 AM, Teresa Johnson <tejohnson@google.com> wrote:
> This patch is pending on trunk, but I would like to get this into google
> branches now as it is causing spurious warnings.
>
> Google ref b/8496800.
>
> This patch allows the unused attribute to be used without warning
> on C++ class members, which are of type FIELD_DECL. This is for
> compatibility with clang, which allows the attribute to be specified on
> class members and struct fields. It looks like more work would need to
> be done to implement the actual unused variable detection and warning
> on FIELD_DECLs, but this change will at least avoid the warning on the
> code that uses the unused attribute in these cases. The documentation at
> http://gcc.gnu.org/onlinedocs/gcc/Variable-Attributes.html also doesn't
> seem to preclude its use on C++ member variables.
>
> Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for google branches?
>
> 2013-04-09  Teresa Johnson  <tejohnson@google.com>
>
>         * c-family/c-common.c (handle_unused_attribute):
>
> Index: c-family/c-common.c
> ===================================================================
> --- c-family/c-common.c (revision 197640)
> +++ c-family/c-common.c (working copy)
> @@ -6320,6 +6320,7 @@ handle_unused_attribute (tree *node, tree name, tr
>
>        if (TREE_CODE (decl) == PARM_DECL
>           || TREE_CODE (decl) == VAR_DECL
> +         || TREE_CODE (decl) == FIELD_DECL
>           || TREE_CODE (decl) == FUNCTION_DECL
>           || TREE_CODE (decl) == LABEL_DECL
>           || TREE_CODE (decl) == TYPE_DECL)
>
> --
> This patch is available for review at http://codereview.appspot.com/8580044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b