Issue 174: RFE: Allow service defs in optimize_for=LITE_RUNTIME if *_generic_service = false

This is a trivial patch to simply remove the error; which means if you have some (java,cpp)_generic_services=true and optimize_for=LITE_RUNTIME, declared services will simply be ignored without any warning or error (if you're generating Python code, services will be generated because there's no LITE_RUNTIME support)

(I do have some code to add an error in google::protobuf::compiler::java::FileGenerator::Validate but it would require adding such a Validate method for C++; do not hesitate to ask me if you want me to try this way, but first read the note below)

IMPORTANT NOTE: I haven't tested the code (not even compiled) as do not have a build environment (I'm using the Windows pre-built binary)

[kenton, 2010-04-19 19:16:28]

Good point.  Instead of removing the error, I changed it to only happen if
one of {cc,java}_generic_services is true.  Committed as revision 326.

On Sat, Apr 17, 2010 at 5:34 PM, <t.broyer@gmail.com> wrote:

> Reviewers: kenton,
>
> Description:
> This is a trivial patch to simply remove the error; which means if you
> have some (java,cpp)_generic_services=true and
> optimize_for=LITE_RUNTIME, declared services will simply be ignored
> without any warning or error (if you're generating Python code, services
> will be generated because there's no LITE_RUNTIME support)
>
> (I do have some code to add an error in
> google::protobuf::compiler::java::FileGenerator::Validate but it would
> require adding such a Validate method for C++; do not hesitate to ask me
> if you want me to try this way, but first read the note below)
>
> IMPORTANT NOTE: I haven't tested the code (not even compiled) as do not
> have a build environment (I'm using the Windows pre-built binary)
>
> Please review this at http://codereview.appspot.com/851048/show
>
> Affected files:
>  src/google/protobuf/descriptor.cc
>
>
> Index: src/google/protobuf/descriptor.cc
> ===================================================================
> --- src/google/protobuf/descriptor.cc   (revision 325)
> +++ src/google/protobuf/descriptor.cc   (working copy)
> @@ -3720,12 +3720,6 @@
>  }
>  void DescriptorBuilder::ValidateServiceOptions(ServiceDescriptor* service,
>     const ServiceDescriptorProto& proto) {
> -  if (IsLite(service->file())) {
> -    AddError(service->full_name(), proto,
> -             DescriptorPool::ErrorCollector::NAME,
> -             "Files with optimize_for = LITE_RUNTIME cannot define
> services.");
> -  }
> -
>   VALIDATE_OPTIONS_FROM_ARRAY(service, method, Method);
>  }
>
>
>
>