Issue 849046: Missing currency RAI

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 849046: Missing currency RAI (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by yangoon1

Modified:
14 years, 1 month ago

Reviewers:
ced, udono

Visibility:
Public.

Patch Set 2 : Adding nummeric code #

Patch Set 3 : Changing numeric code to match english date format #

Total comments: 1

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	currency.xml	View	1 2	1 chunk	+7 lines, -0 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/849046/diff/1/2 File currency.xml (right): http://codereview.appspot.com/849046/diff/1/2#newcode1059 currency.xml:1059: <record model="currency.currency" id="rai"> currency are generated by script/currencies.py http://codereview.appspot.com/849046/diff/1/2#newcode1062 ...

14 years, 1 month ago (2010-04-01 17:34:40 UTC) #1

udono

http://codereview.appspot.com/849046/diff/1/2 File currency.xml (right): http://codereview.appspot.com/849046/diff/1/2#newcode1062 currency.xml:1062: <field name="numeric_code"></field> AFAIK the missing numeric code is 0104

14 years, 1 month ago (2010-04-01 17:39:35 UTC) #2

ced

14 years, 1 month ago (2010-04-01 17:42:46 UTC) #3

yangoon1

14 years, 1 month ago (2010-04-01 17:45:45 UTC) #4

udono

14 years, 1 month ago (2010-04-01 17:51:32 UTC) #5

http://codereview.appspot.com/849046/diff/10001/11001
File currency.xml (right):

http://codereview.appspot.com/849046/diff/10001/11001#newcode1062
currency.xml:1062: <field name="numeric_code">0401</field>
ah, yes it is right 0401 because it is depending on date format mmddyy. Sorry
for wrong trail

Expand All Messages | Collapse All Messages