Issue 849044: code review 849044: go spec: clarification of type declarations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 849044: code review 849044: go spec: clarification of type declarations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by gri

Modified:
15 years ago

Reviewers:
rsc

CC:
r, rsc, golang-dev

Visibility:
Public.

Description

go spec: clarification of type declarations

Patch Set 2 : code review 849044: go spec: clarification of type declarations #

Total comments: 1

Patch Set 3 : code review 849044: go spec: clarification of type declarations #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	doc/go_spec.html	View	1 2	3 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gri

Hello r, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-31 23:13:26 UTC) #1

gri

I made this even more explicit; the initial sentence was contradictory. PTAL. On Wed, Mar ...

15 years ago (2010-03-31 23:27:30 UTC) #3

LGTM http://codereview.appspot.com/849044/diff/4001/5001 File doc/go_spec.html (right): http://codereview.appspot.com/849044/diff/4001/5001#newcode1711 doc/go_spec.html:1711: <a href="#Properties_of_types_and_values">identical</a> with the existing type. s/with/to/

15 years ago (2010-03-31 23:33:43 UTC) #4

gri

*** Submitted as http://code.google.com/p/go/source/detail?r=02ee385e4ce6 *** go spec: clarification of type declarations R=r, rsc CC=golang-dev http://codereview.appspot.com/849044

15 years ago (2010-03-31 23:37:24 UTC) #5

rsc1

15 years ago (2010-04-01 00:25:22 UTC) #6

Given: type MyError os.Error

MyError and os.Error are not identical.
They have different spellings, and the primary
definition of identical, in my mind, is that
types are identical if they are spelled the same
way.  

Even ignoring that intuition, *MyError and *os.Error
or []MyError and []os.Error are not identical, and
the only explanation for that is that the base types
are not identical.

Expand All Messages | Collapse All Messages