Issue 841042: code review 841042: Freetype-Go: Initial code check-in.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 841042: code review 841042: Freetype-Go: Initial code check-in. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by nigeltao

Modified:
14 years, 7 months ago

Reviewers:

CC:
r, rsc, golang-dev

Visibility:
Public.

Description

Freetype-Go: Initial code check-in.

Patch Set 1 #

Patch Set 2 : code review 841042: Freetype-Go: Initial code check-in. #

Patch Set 3 : code review 841042: Freetype-Go: Initial code check-in. #

Total comments: 1

Patch Set 4 : code review 841042: Freetype-Go: Initial code check-in. #

Patch Set 5 : code review 841042: Freetype-Go: Initial code check-in. #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1286 lines, -0 lines)			Patch
A	AUTHORS	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	CONTRIBUTORS	View	1 2 3 4	1 chunk	+31 lines, -0 lines	0 comments	Download
A	LICENSE	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	README	View	1 2 3	1 chunk	+19 lines, -0 lines	0 comments	Download
A	example/raster/main.go	View		1 chunk	+173 lines, -0 lines	0 comments	Download
A	freetype/raster/Makefile	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
A	freetype/raster/raster.go	View		1 chunk	+517 lines, -0 lines	0 comments	Download
A	licenses/ftl.txt	View	1 2 3 4	1 chunk	+169 lines, -0 lines	0 comments	Download
A	licenses/gpl.txt	View		1 chunk	+340 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-04-01 15:26:46 UTC) #1

rsc1

LGTM Very cool. From a Go standpoint the code looks great. I trust you that ...

14 years, 7 months ago (2010-04-01 15:56:15 UTC) #2

nigeltao

14 years, 7 months ago (2010-04-01 23:08:21 UTC) #3

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=6ae1e706006d ***

Freetype-Go: Initial code check-in.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/841042

Expand All Messages | Collapse All Messages