Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 840043: code review 840043: gc: compile s == "" as len(s) == 0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by rsc
Modified:
15 years, 3 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: compile s == "" as len(s) == 0

Patch Set 1 #

Patch Set 2 : code review 840043: gc: compile s == "" as len(s) == 0 #

Patch Set 3 : code review 840043: gc: compile s == "" as len(s) == 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/cmd/gc/walk.c View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 3 months ago (2010-04-11 22:24:22 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=b331e0e9f301 *** gc: compile s == "" as len(s) == 0 R=ken2 ...
15 years, 3 months ago (2010-04-11 22:24:50 UTC) #2
ken3
15 years, 3 months ago (2010-04-12 05:02:56 UTC) #3
LGTM

i like the badgerbadger
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b