Issue 837041: code review 837041: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 837041: code review 837041: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by rsc

Modified:
15 years, 4 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

fix build

Patch Set 1 #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/cmd/godoc/godoc.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 4 months ago (2010-03-29 20:30:28 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=915b24b0d904 *** fix build R=gri CC=golang-dev http://codereview.appspot.com/837041

15 years, 4 months ago (2010-03-29 20:30:39 UTC) #2

gri

15 years, 4 months ago (2010-03-29 21:04:12 UTC) #3

LGTM

On Mon, Mar 29, 2010 at 1:30 PM, <rsc@golang.org> wrote:

> Reviewers: gri,
>
> Message:
> Hello gri (cc: golang-dev@googlegroups.com),
>
>
> I'd like you to review this change.
>
>
> Description:
> fix build
>
> Please review this at http://codereview.appspot.com/837041/show
>
> Affected files:
>  M src/cmd/godoc/godoc.go
>
>
> Index: src/cmd/godoc/godoc.go
> ===================================================================
> --- a/src/cmd/godoc/godoc.go
> +++ b/src/cmd/godoc/godoc.go
> @@ -1383,9 +1383,9 @@
>                                nwords, nspots := index.Size()
>                                log.Stderrf("index updated (%gs, %d unique
> words, %d spots)", secs, nwords, nspots)
>                        }
> -                       log.Stderrf("bytes=%d footprint=%d\n",
> runtime.MemStats.HeapAlloc, runtime.MemStats.InusePages<<12)
> +                       log.Stderrf("bytes=%d footprint=%d\n",
> runtime.MemStats.HeapAlloc, runtime.MemStats.Sys)
>                        runtime.GC()
> -                       log.Stderrf("bytes=%d footprint=%d\n",
> runtime.MemStats.HeapAlloc, runtime.MemStats.InusePages<<12)
> +                       log.Stderrf("bytes=%d footprint=%d\n",
> runtime.MemStats.HeapAlloc, runtime.MemStats.Sys)
>                }
>                time.Sleep(1 * 60e9) // try once a minute
>        }
>
>
>

Expand All Messages | Collapse All Messages