Issue 8189043: Tempo and Rehearsal marks horizontal positioning; issue 3279

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8189043: Tempo and Rehearsal marks horizontal positioning; issue 3279 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by Keith

Modified:
10 years, 10 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Provide \markLengthOn and \markLengthOff

Patch Set 2 : old behavior with \markLengthOff; adjust regtests #

Patch Set 3 : fix docs example #

Patch Set 4 : tempo indications to right edge of KeySignature #

Patch Set 5 : tempo indications on TimeSignature, or first note #

Total comments: 2

Patch Set 6 : try again, without affecting page-breaking #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -1 line)			Patch
M	Documentation/learning/tweaks.itely	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Documentation/notation/rhythms.itely	View	1 2 3 4 5	1 chunk	+20 lines, -0 lines	0 comments	Download
M	Documentation/notation/text.itely	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	input/regression/metronome-marking.ly	View	1 2 3 4 5	1 chunk	+3 lines, -1 line	0 comments	Download
M	ly/property-init.ly	View	1 2 3 4 5	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lemzwerg

LGTM. Great work! https://codereview.appspot.com/8189043/diff/45001/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/8189043/diff/45001/Documentation/learning/tweaks.itely#newcode2288 Documentation/learning/tweaks.itely:2288: The corresponding spacing behavior for rehearsal ...

11 years ago (2013-04-18 08:17:46 UTC) #1

Keith

11 years ago (2013-04-18 15:38:43 UTC) #2

https://codereview.appspot.com/8189043/diff/45001/Documentation/learning/twea...
File Documentation/learning/tweaks.itely (right):

https://codereview.appspot.com/8189043/diff/45001/Documentation/learning/twea...
Documentation/learning/tweaks.itely:2288: The corresponding spacing behavior for
rehearsal marks and tempo
On 2013/04/18 08:17:46, lemzwerg wrote:
> Do you intend to start a new paragraph here?
No, there is no blank line.  It is just easier to read the input if I start the
new bar on a new line.

Expand All Messages | Collapse All Messages